feature: Map events to an attribute flag for selectPlacements#41
Conversation
….Rokt for session attribute management
| ]); | ||
| }); | ||
|
|
||
| it('should parse a settings string with a stringified number value correctly', () => { |
There was a problem hiding this comment.
I'm still unclear about the meaning of this test. what about a stringified number is being tested? saw that you resolved the original comment but didn't see any changes
There was a problem hiding this comment.
The purpose of this test is to verify that if a setting string is parsed, the string hashes in the jsmap and map properties are not converted to numbers, but remain as strings.
For example, "jsmap":"-1484452948" should be come jsmap: '-1484452948' (sting) and not -1484452948 (number)
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to map events to attribute flags for the selectPlacements method in the Rokt forwarder. When configured events are fired, they set local session attributes that are then included in placement selection calls.
Key changes:
- Added event mapping configuration parsing and lookup generation
- Implemented event processing to set local session attributes for mapped events
- Enhanced
selectPlacementsto include local session attributes in the request
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Rokt-Kit.js | Implements core event mapping functionality, event processing, and local session attribute integration |
| test/src/tests.js | Adds comprehensive test coverage for the new event mapping features and helper functions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Robert Ing <ring@mparticle.com>
…e-integrations/mparticle-javascript-integration-rokt into feature/SDKE-106-rta-attributes
Summary
Map events to an attribute flag for selectPlacements
Testing Plan