feat: Extend product attribute mapping/ord_id to all ecommerce; support sendProductNamesAsContents

[jaissica12]

Instructions

1. PR target branch should be against development
2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

• Extended existing product attribute mapping functionality to AddToCart, RemoveFromCart, Checkout and Purchase event.
• If sendProductNamesasContents is enabled, update content name to array of product names
• Add related tests

Testing Plan

• Was this tested locally? If not, explain why.
• {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

• Closes https://go/j/SDKE-643

[rmi22186]

var contents is being redeclared here. best to declar it at the top of the file rather than twice at 234/257

[jaissica12]

Moved contents declaration to the top of the logCommerceEvent function (line 171)

[rmi22186]

just 1 minor comment

[rmi22186]

There's probably a fair amount of refactoring that can be done to this file given all the if/else. But this is in line with the necessary change that the customer needs and we can do a broader refactor after blackout I'd say. Adding @samdozor for final approval.

[alexs-mparticle]

I think a cleaner approach would be to have the function just return the content_name value, and you can just assign it to the params. This way it's not mutating one of the arguments.

For example, the invocation becomes:

params['content_name'] = setProductNamesAsContentName(event.ProductAction.ProductList);

Suggested change

	function setProductNamesAsContentName(params, productList) {
	if (productList) {
	params['content_name'] = productList
	.filter(function(product) {
	return product && product.Name;
	})
	.map(function(product) {
	return product.Name;
	});
	}
	}
	function setProductNamesAsContentName(productList) {
	if (productList) {
	return productList
	.filter(function(product) {
	return product && product.Name;
	})
	.map(function(product) {
	return product.Name;
	});
	}
	}

[jaissica12]

@alexs-mparticle Thanks for the feedback! I’ve updated the return type as suggested. Refactored the logic for setting content_name: instead of assigning the result directly, we now call buildProductNames(event.ProductAction.ProductList) and only set params['content_name'] if the returned array is non-empty, similar to how params['contents'] is handled.

For consistency, I removed the helper function setOrderId and moved the order_id assignment inline next to the other parameter assignments

[rmi22186]

From a product (and code simplification/maintainability) perspective, I think that these new settings should support all of the commerce events types.

The reason being - we have one customer who wants this to be in a few commerce types because those are the only ones they currently use. But if another customer does use a separate commerce event type, they would expect the settings selected in the UI to apply to all commerce event types, not just a few.

So let's move logic related to sendProductNamesAsContents and order_id to above and outside of when we do specific commerce event typ elogic. (I'd say line 192.

[jaissica12]

I agree, that makes sense. I’ve moved the logic for sendProductNamesAsContents and order_id so that it runs before any event-type-specific commerce logic.

[rmi22186]

similar to the feedback I gave before, I think we should simplify this further and have the buildProductContents be top level so it applies to every commerce event type

[jaissica12]

Updated!