Skip to content

fix: Add Nil Check Around Unassigned Logic #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BrandonStalnaker merged 2 commits into from
Sep 18, 2025
Merged

fix: Add Nil Check Around Unassigned Logic #37

BrandonStalnaker merged 2 commits into from
Sep 18, 2025

Conversation

@BrandonStalnaker
Copy link
Collaborator

@BrandonStalnaker BrandonStalnaker commented Sep 18, 2025 •
edited
Loading

Summary

  • I was asked to disable this feature from going out in this release and rather than remove the other bug fixes included in that PR I elected to only remove the new functionality of defaulting to nil rather than defaulting to other.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested locally and through unit tests

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker self-assigned this Sep 18, 2025
@BrandonStalnaker BrandonStalnaker requested a review from a team as a code owner September 18, 2025 13:38
@denischilik denischilik self-requested a review September 18, 2025 14:25
denischilik
denischilik previously approved these changes Sep 18, 2025
View reviewed changes
@BrandonStalnaker BrandonStalnaker force-pushed the fix/Remove-Unassigned-Logic-For-Release branch from a7956d6 to 4add168 Compare September 18, 2025 16:05
@BrandonStalnaker BrandonStalnaker changed the title fix: Remove Unassigned Logic for this Release fix: Add Nil Check Around Unassigned Logic Sep 18, 2025
denischilik
denischilik previously approved these changes Sep 18, 2025
View reviewed changes
Copy link

@denischilik denischilik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BrandonStalnaker
BrandonStalnaker commented Sep 18, 2025
View reviewed changes
@denischilik denischilik self-requested a review September 18, 2025 17:03
denischilik
denischilik approved these changes Sep 18, 2025
View reviewed changes
Copy link

@denischilik denischilik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrandonStalnaker BrandonStalnaker merged commit 21f2c62 into development Sep 18, 2025
5 checks passed
@BrandonStalnaker BrandonStalnaker deleted the fix/Remove-Unassigned-Logic-For-Release branch September 18, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickolas-dimitrakas nickolas-dimitrakas nickolas-dimitrakas approved these changes

@denischilik denischilik denischilik approved these changes

Assignees

@BrandonStalnaker BrandonStalnaker

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BrandonStalnaker @nickolas-dimitrakas @denischilik