Skip to content

fix: Place RoktEmbeddedView within mparticle.rokt namespace #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mansi-mParticle merged 1 commit into from
Apr 9, 2025
Merged

fix: Place RoktEmbeddedView within mparticle.rokt namespace #5

Mansi-mParticle merged 1 commit into from
Apr 9, 2025

Conversation

@Mansi-mParticle
Copy link
Collaborator

@Mansi-mParticle Mansi-mParticle commented Apr 9, 2025

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Changed the namespace of RoktEmbeddedView from mparticle.RoktEmbeddedView to com.mparticle.rokt.RoktEmbeddedView.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested with sample app

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@Mansi-mParticle Mansi-mParticle requested a review from rmi22186 April 9, 2025 19:47
@Mansi-mParticle Mansi-mParticle changed the title fix: changed rokt widget namespace fix: Place RoktEmbeddedView within mparticle.rokt namespace Apr 9, 2025
@Mansi-mParticle Mansi-mParticle merged commit 8c84b66 into development Apr 9, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rmi22186 rmi22186 rmi22186 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mansi-mParticle @rmi22186