Skip to content

feat: add device identifiers to attributes #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nickolas-dimitrakas wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: add device identifiers to attributes #107

nickolas-dimitrakas wants to merge 5 commits into from

Conversation

@nickolas-dimitrakas
Copy link

@nickolas-dimitrakas nickolas-dimitrakas commented Dec 15, 2025 •
edited
Loading

Summary

  • Added Google Advertising ID (GAID) support to addIdentityAttributes method in RoktKit
  • GAID is automatically included in identity attributes when available and advertiser is Google
  • Added mockito-inline dependency for static method mocking in tests

Testing Plan

  • Was this tested locally?
  • Tested using ./gradlew testDebugUnitTest

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

  • Closes NO JIRA

@nickolas-dimitrakas nickolas-dimitrakas self-assigned this Dec 15, 2025
@nickolas-dimitrakas nickolas-dimitrakas requested a review from a team as a code owner December 15, 2025 20:59
thomson-t
thomson-t previously approved these changes Dec 15, 2025
View reviewed changes
Mansi-mParticle
Mansi-mParticle reviewed Dec 15, 2025
View reviewed changes
@nickolas-dimitrakas @Mansi-mParticle
address @Mansi-mParticle comments
a765622 
Co-Authored-By: Mansi-mParticle <159845845+Mansi-mParticle@users.noreply.github.com>
@nickolas-dimitrakas @Mansi-mParticle
Update src/main/kotlin/com/mparticle/kits/RoktKit.kt
ad4222e 
Co-authored-by: Mansi-mParticle <159845845+Mansi-mParticle@users.noreply.github.com>
Mansi-mParticle
Mansi-mParticle previously approved these changes Dec 16, 2025
View reviewed changes
Copy link
Collaborator

@Mansi-mParticle Mansi-mParticle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jamesnrokt
jamesnrokt reviewed Dec 16, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samdozor samdozor Awaiting requested review from samdozor

@thomson-t thomson-t Awaiting requested review from thomson-t

@jamesnrokt jamesnrokt Awaiting requested review from jamesnrokt

@Mansi-mParticle Mansi-mParticle Awaiting requested review from Mansi-mParticle

At least 1 approving review is required to merge this pull request.

Assignees

@nickolas-dimitrakas nickolas-dimitrakas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nickolas-dimitrakas @thomson-t @Mansi-mParticle @jamesnrokt