Handle null consent state during appsflyer kit init when GDPR is enabled#120
Open
ankitsingh08 wants to merge 1 commit into
Open
Handle null consent state during appsflyer kit init when GDPR is enabled#120ankitsingh08 wants to merge 1 commit into
ankitsingh08 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
org.json.JSONException: Value null of type org.json.JSONObject$1 cannot be converted to JSONObjectAppsFlyerKit.onKitCreate()readscurrentUser?.consentState, but consent may legitimately still benullat that point if no consent state has been set yet.setConsent()proceeded into consent parsing and attempted to parseconsentState.toString()even whenconsentStatewasnull.AppsFlyerKit.onKitCreate()callssetConsent(currentUser?.consentState)parseToNestedMap(consentState.toString())is invoked with a null consent stateWhat Has Changed
ConsentStateis present.Screenshots/Video
Checklist
Additional Notes
./gradlew testDebugUnitTest --tests com.mparticle.kits.AppsflyerKitTestsonConsentStateUpdated()flow continues to apply mapped consent values as before