feat: Add support to forward SubscriptionGroupIds #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| private fun getSubscriptionGroupIds(subscriptionGroupMap: String): MutableMap<String, String> { | ||
| val subscriptionGroupsArray = JSONArray(subscriptionGroupMap) |
Collaborator
There was a problem hiding this comment.
Suggested change
| val subscriptionGroupsArray = JSONArray(subscriptionGroupMap) | |
| if (subscriptionGroupMap.isEmpty()) { | |
| return subscriptionGroupIds | |
| } | |
| val subscriptionGroupsArray = JSONArray(subscriptionGroupMap) |
Check if the map string is empty before creating the JSON array, so you can avoid a JSONException
| subscriptionGroupIds[key] = value | ||
| } | ||
|
|
||
| return subscriptionGroupIds |
Collaborator
There was a problem hiding this comment.
Suggested change
| return subscriptionGroupIds | |
Not needed because the code already returns subscriptionGroupIds above.
| } else { | ||
| Logger.warning( | ||
| "unable to set Subscription Group ID for user attribute: " | ||
| + key + "due to invalid value data type. expected value data type should be Boolean" |
Collaborator
There was a problem hiding this comment.
Suggested change
| + key + "due to invalid value data type. expected value data type should be Boolean" | |
| + key + " due to invalid value data type. expected value data type should be Boolean" |
rmi22186
merged commit 22a9786
into
mparticle-integrations:development
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)