chore: bump android-sdk-ui from 23.3.0 to 24.3.0 and replace all com.appboy imports with com.braze #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps org.sonarqube from 3.5.0.2730 to 4.0.0.2929. --- updated-dependencies: - dependency-name: org.sonarqube dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
samdozor
force-pushed
the
development
branch
from
e040f53 to
d0133de
Compare
techouse
changed the title
Contributor
Author
|
Can someone please look at this PR? |
mmustafa-tse
approved these changes
Apr 21, 2023
Contributor
mmustafa-tse
left a comment
mmustafa-tse
left a comment
There was a problem hiding this comment.
LGTM! @markvdouw let me know how it looks on your end
markvdouw
suggested changes
Apr 24, 2023
Contributor
Author
|
@mmustafa-tse & @markvdouw can you have another look at this please? |
mmustafa-tse
approved these changes
Apr 26, 2023
Contributor
mmustafa-tse
left a comment
mmustafa-tse
left a comment
There was a problem hiding this comment.
LGTM! already tested this code. awaiting @markvdouw
|
I will wait for test to pass, merge it and run will be deployed soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #115, #128 and addresses #117
The Braze Android SDK v24 replaced the
com.appboyclasspath withcom.brazeas outlined in the changelog.Currently, this mParticle kit still looks for
com.appboywhich crashes the app. This PR fixes it by replacing allcom.appboyimports with theircom.brazeequivalents.com.appboy.enums.Gendercom.braze.enums.Gendercom.appboy.enums.Monthcom.braze.enums.Monthcom.appboy.enums.SdkFlavorcom.braze.enums.SdkFlavorcom.appboy.enums.NotificationSubscriptionTypecom.braze.enums.NotificationSubscriptionTypeTesting Plan
android-appboy-kit-release.aarand impoted that locally. Everything works OK.