-
Notifications
You must be signed in to change notification settings - Fork 512
Fix#1921: Extended the Gruntfile to include eslint #1971
Conversation
|
I fixed the above errors |
humphd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good. Any objections? We can extend the rules as we go.
|
cc @dsych. Let's build on this PR to also add prettier fix like we are doing in Brackets. mozilla/brackets#703 |
|
Can we merge this @humphd - seems like the problems were addressed. |
|
Tested this again today, and it needs a few things:
|
humphd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my earlier comment.
|
Since we're switching to webpack, we would need to run eslint there. Feel free to take on that issue once the webpack code is merged in. Closing, in favor of that. |
@Pomax I installed eslint for grunt and modified the Gruntfile.js file to include the eslint task.

The only rule I can think of to enable and check for is the indent rule. I added it in the .eslintrc.json file and specified that the indent needs to be 2 spaces. If there are any other rules I need to add please let me know.
I also specified the ecmaVersion for the parser to be 6 because if I don't it will give many parsing errors like the keyword
letis reserved andconstis reserved.Currently when I run
npm testI get 7 errors because some files don't use 2 spaces. This is how the errors look: