Fix nvcc dryrun parsing for CUDA 13.3#2722
Open
mbrobbel wants to merge 2 commits into
Open
Conversation
sylvestre
reviewed
May 28, 2026
| let input_loc = match language { | ||
| Language::Ptx => arguments | ||
| .iter() | ||
| .position(|arg| arg.to_string_lossy().ends_with(".cpp1.ii")), |
Collaborator
There was a problem hiding this comment.
is it reasonable to hardcode .cpp1.ii ?
Author
There was a problem hiding this comment.
I think so:
Lines 824 to 827 in 8825b4a
But maybe we should move this into some helpers to make it more obvious?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sccacheassumednvcc-generatedciccandptxasinputs were always at a fixed offset near the end of the command line. With CUDA 13.3.33,ciccdryrun output can place--simt-onlyafter the input file, which makes the old positional parser treat--simt-onlyas the input instead ofkernel.cpp1.ii.That can prevent
sccachefrom grouping theciccandptxasdevice compilation steps correctly. Later,fatbinaryfails because the expected.cubinfiles were never produced.Changes
ciccinputs by.cpp1.iiextension instead of fixed position.ptxasinputs by.ptxextension instead of fixed position.ciccinput before--simt-only.ptxasinput detection by.ptx.nvccdryrun grouping coverage for CUDA 13.3-style--simt-only.