feat: avoid sccache wrapper when resolving compiler#2720
Open
iTrooz wants to merge 1 commit into
Open
Conversation
Make /bin/sccache /usr/lib/sccache/gcc main.c work
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2720 +/- ##
==========================================
- Coverage 74.41% 74.34% -0.07%
==========================================
Files 70 70
Lines 39211 39403 +192
==========================================
+ Hits 29177 29296 +119
- Misses 10034 10107 +73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows you to do things like
/bin/sccache /usr/lib/sccache/gcc main.cIt can seem weird at first, but the same mechanism already existed for ccache. Personally, I had an issue with a build system that insisted on putting sccache as a wrapper, when I already had gcc as a sccache symlink, which is what prompted that PR
there's a change of behaviour for absolute path (why are now still changed to avoid wrappers) so I would understand if you didn't accept this PR