Normalize -f*-prefix-map args via SCCACHE_BASEDIRS#2673
Open
larseggert wants to merge 1 commit intomozilla:mainfrom
Open
Normalize -f*-prefix-map args via SCCACHE_BASEDIRS#2673larseggert wants to merge 1 commit intomozilla:mainfrom
-f*-prefix-map args via SCCACHE_BASEDIRS#2673larseggert wants to merge 1 commit intomozilla:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2673 +/- ##
==========================================
+ Coverage 72.83% 73.41% +0.58%
==========================================
Files 68 68
Lines 37348 37389 +41
==========================================
+ Hits 27201 27450 +249
+ Misses 10147 9939 -208 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
These compound flags embed absolute paths that `strip_basedirs` cannot reach via preprocessor-output normalization, causing cache misses when the same sources are built from different directories. Extract the `OLD` path component and strip basedir prefixes from it before hashing.
larseggert
force-pushed
the
fix-normalize_prefix_map_arg
branch
from
0310045 to
e1ba867
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These compound flags embed absolute paths that
strip_basedirscannot reach via preprocessor-output normalization, causing cache misses when the same sources are built from different directories. Extract theOLDpath component and strip basedir prefixes from it before hashing.