Skip to content

RMST-260: git-export: update metadata even if records haven't changed #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leplatrem wants to merge 1 commit into
base: main
Choose a base branch
from
Open

RMST-260: git-export: update metadata even if records haven't changed #1119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions cronjobs/src/commands/git_export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,20 +486,21 @@ async def repo_sync_content(
print(f"Created commit {bid}/{cid}@{timestamp}: {commit_oid}")
changed_branches.add(refname)

# Tag the commit with the timestamp for traceability. If it already
# exists, ignore the error (idempotent tagging behavior).
# If the tag already exists (that happens when records don't change but metadata does),
# we move it to the new commit.
tag_name = f"{GIT_REF_PREFIX}timestamps/{bid}/{cid}/{timestamp}"
try:
repo.create_tag(
tag_name,
commit_oid,
pygit2.GIT_OBJECT_COMMIT,
author,
f"{bid}/{cid}/{timestamp}",
)
print(f"Created tag {tag_name}")
created_tags.append(tag_name)
except pygit2.AlreadyExistsError: # pragma: no cover
print(f"Tag {tag_name} already exists, skipping.")
tag_exists = repo.references.get(f"refs/tags/{tag_name}") is not None
if tag_exists:
Copy link
Contributor

@alexcottner alexcottner Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should consider breaking repo_sync_content into multiple smaller functions to make unit testing easier. We can do that as a follow-up PR if we want to push this out quickly though.

repo.references.delete(f"refs/tags/{tag_name}")

repo.create_tag(
tag_name,
commit_oid,
pygit2.GIT_OBJECT_COMMIT,
author,
f"{bid}/{cid}@{timestamp} ({dtcollection})",
)
print(f"{'Created' if not tag_exists else 'Moved'} tag {tag_name}")
created_tags.append(tag_name)

return changed_attachments, changed_branches, created_tags
Loading