Skip to content

Add cover support to at2x() mixin #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janbrasna wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add cover support to at2x() mixin #1112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9d1596
Support cover in at2x mixin
janbrasna Jan 18, 2026
2327837
Update CHANGELOG
janbrasna Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ Introducing theme variables! CSS variables beginning with `--theme-` will adjust

* To come in follow up PR.

## Bug Fixes

* **css:** at2x mixin doesn't support single keyword values (#751)

## Migration Tips

See the [Migration Guide](https://protocol.mozilla.org/docs/usage/migration) for automated scripts (VS Code find/replace and terminal commands) to help with these changes.
Expand Down
11 changes: 7 additions & 4 deletions assets/sass/protocol/includes/mixins/_at2x.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,16 @@
// example.png
// example-high-res.png
// Usage:
// @include at2x('/media/img/foo.png', 100px, 100px);
// @include at2x('/media/img/example.png', 100px, 100px);
// @include at2x('/media/img/example.jpg', auto, 200px);
// @include at2x('/media/img/example.avif', 25%);
// @include at2x('/media/img/example.webp', contain);

@mixin at2x($path, $w: auto, $h: auto) {
$hr-suffix: '-high-res';

// Do not set height to auto if width is contain
@if $w == 'contain' {
// Do not set height if `contain` or `cover` is passed as the first param
@if $w == 'contain' or $w == 'cover' {
$h: #{''};
}

Expand All @@ -28,7 +31,7 @@
// Loop through the image path and find the position of
// the dot to determine the file extension.
// Subtract from string length to make an end point that
// is always lower than the start point s the loop always
// is always lower than the start point so the loop always
// increments (10 is an arbitrary number).
@for $i from $length through $length - 10 {
@if $position == -1 {
Expand Down