Fix dimensions for newer social icons #93
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SVG icons either need to be at 16px (like fx, fb, ig, gh, pocket…) or if 24px or any other size (e.g. spotify, tiktok & mastodon) only the
viewBoxwithoutwidthandheightmust be present to work in bedrock footerbackground-imagein WebKit.Mastodon SVG icons are the only ones in 24px that also declare dimensions, making migration to protocol_assets buggy:
(PoC: janbrasna/bedrock@5653020)
Leaving out the dimensions fixes this and enables removal of the local overrides in footer.