Skip to content

Bug 2024765 - Remove redundant significance column #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mgaudet wants to merge 2 commits into from
Closed

Bug 2024765 - Remove redundant significance column #1018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3662503
Bug 2024765 - Remove significance column from Mann-Whitney-U subtest …
mgaudet Mar 19, 2026
c07ec9c
Bug 2024765 - Update test expectations after removing significance co…
mgaudet Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 41 additions & 71 deletions src/__tests__/CompareResults/SubtestsResultsView.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ function summarizeVisibleRows(testVersion?: TestVersion) {
}
const rowClasses =
testVersion === 'mann-whitney-u'
? ['.delta', '.significance', '.effects']
? ['.delta', '.effects']
: ['.delta', '.confidence'];
const rowString = rowClasses
.map((selector) => row.querySelector(selector)?.textContent.trim())
Expand Down Expand Up @@ -508,11 +508,11 @@ describe('SubtestsResultsView Component Tests for mann-whitney-u testVersion', (
await setupForSorting();
// Initial view (alphabetical ordered, even if "sort by subtests" isn't specified
expect(summarizeVisibleRows('mann-whitney-u')).toEqual([
'browser.html: -0.04, Not significant, 15.00%',
'dhtml.html: 0.02, Significant, 60.00%',
'improvement.html: -0.05, Significant, 50.00%',
'regression.html: 0.12, Significant, 25.00%',
'tablemutation.html: 0.01, -, 45.00%',
'browser.html: -0.04, 15.00%',
'dhtml.html: 0.02, 60.00%',
'improvement.html: -0.05, 50.00%',
'regression.html: 0.12, 25.00%',
'tablemutation.html: 0.01, 45.00%',
]);

// Sort by Delta
Expand All @@ -523,11 +523,11 @@ describe('SubtestsResultsView Component Tests for mann-whitney-u testVersion', (
// Sort descending
await user.click(deltaButton);
expect(summarizeVisibleRows('mann-whitney-u')).toEqual([
'regression.html: 0.12, Significant, 25.00%',
'improvement.html: -0.05, Significant, 50.00%',
'browser.html: -0.04, Not significant, 15.00%',
'dhtml.html: 0.02, Significant, 60.00%',
'tablemutation.html: 0.01, -, 45.00%',
'regression.html: 0.12, 25.00%',
'improvement.html: -0.05, 50.00%',
'browser.html: -0.04, 15.00%',
'dhtml.html: 0.02, 60.00%',
'tablemutation.html: 0.01, 45.00%',
]);

// It should have the "descending" SVG.
Expand All @@ -538,58 +538,28 @@ describe('SubtestsResultsView Component Tests for mann-whitney-u testVersion', (
// Sort ascending
await user.click(deltaButton);
expect(summarizeVisibleRows('mann-whitney-u')).toEqual([
'tablemutation.html: 0.01, -, 45.00%',
'dhtml.html: 0.02, Significant, 60.00%',
'browser.html: -0.04, Not significant, 15.00%',
'improvement.html: -0.05, Significant, 50.00%',
'regression.html: 0.12, Significant, 25.00%',
'tablemutation.html: 0.01, 45.00%',
'dhtml.html: 0.02, 60.00%',
'browser.html: -0.04, 15.00%',
'improvement.html: -0.05, 50.00%',
'regression.html: 0.12, 25.00%',
]);
// It should have the "ascending" SVG.
expect(deltaButton).toMatchSnapshot();
// It should be persisted in the URL
expectParameterToHaveValue('sort', 'delta|asc');

// Sort by Significance descending
const significanceButton = screen.getByRole('button', {
name: /Significance.*sort/,
});
await user.click(significanceButton);
expect(summarizeVisibleRows('mann-whitney-u')).toEqual([
'browser.html: -0.04, Not significant, 15.00%',
'tablemutation.html: 0.01, -, 45.00%',
'dhtml.html: 0.02, Significant, 60.00%',
'regression.html: 0.12, Significant, 25.00%',
'improvement.html: -0.05, Significant, 50.00%',
]);
// It should have the "no sort" SVG.
expect(deltaButton).toMatchSnapshot();
// It should have the "descending" SVG.
expect(significanceButton).toMatchSnapshot();
// It should be persisted in the URL
expectParameterToHaveValue('sort', 'significance|desc');

// Sort by Significance ascending
await user.click(significanceButton);
expect(summarizeVisibleRows('mann-whitney-u')).toEqual([
'improvement.html: -0.05, Significant, 50.00%',
'regression.html: 0.12, Significant, 25.00%',
'dhtml.html: 0.02, Significant, 60.00%',
'tablemutation.html: 0.01, -, 45.00%',
'browser.html: -0.04, Not significant, 15.00%',
]);
expectParameterToHaveValue('sort', 'significance|asc');

// Sort by Effect Size descending
const effectButton = screen.getByRole('button', {
name: /Effect Size \(%\).*sort/,
});
await user.click(effectButton);
expect(summarizeVisibleRows('mann-whitney-u')).toEqual([
'dhtml.html: 0.02, Significant, 60.00%',
'improvement.html: -0.05, Significant, 50.00%',
'tablemutation.html: 0.01, -, 45.00%',
'regression.html: 0.12, Significant, 25.00%',
'browser.html: -0.04, Not significant, 15.00%',
'dhtml.html: 0.02, 60.00%',
'improvement.html: -0.05, 50.00%',
'tablemutation.html: 0.01, 45.00%',
'regression.html: 0.12, 25.00%',
'browser.html: -0.04, 15.00%',
]);

// It should have the "descending" SVG.
Expand All @@ -600,11 +570,11 @@ describe('SubtestsResultsView Component Tests for mann-whitney-u testVersion', (
// Sort by Effect Size ascending
await user.click(effectButton);
expect(summarizeVisibleRows('mann-whitney-u')).toEqual([
'browser.html: -0.04, Not significant, 15.00%',
'regression.html: 0.12, Significant, 25.00%',
'tablemutation.html: 0.01, -, 45.00%',
'improvement.html: -0.05, Significant, 50.00%',
'dhtml.html: 0.02, Significant, 60.00%',
'browser.html: -0.04, 15.00%',
'regression.html: 0.12, 25.00%',
'tablemutation.html: 0.01, 45.00%',
'improvement.html: -0.05, 50.00%',
'dhtml.html: 0.02, 60.00%',
]);
expectParameterToHaveValue('sort', 'effects|asc');
});
Expand All @@ -613,11 +583,11 @@ describe('SubtestsResultsView Component Tests for mann-whitney-u testVersion', (
await setupForSorting({ extraParameters: 'sort=delta|asc' });
await screen.findByText('dhtml.html');
expect(summarizeVisibleRows('mann-whitney-u')).toEqual([
'tablemutation.html: 0.01, -, 45.00%',
'dhtml.html: 0.02, Significant, 60.00%',
'browser.html: -0.04, Not significant, 15.00%',
'improvement.html: -0.05, Significant, 50.00%',
'regression.html: 0.12, Significant, 25.00%',
'tablemutation.html: 0.01, 45.00%',
'dhtml.html: 0.02, 60.00%',
'browser.html: -0.04, 15.00%',
'improvement.html: -0.05, 50.00%',
'regression.html: 0.12, 25.00%',
]);
// It should have the "ascending" SVG.
expect(screen.getByRole('button', { name: /Delta/ })).toMatchSnapshot();
Expand All @@ -627,11 +597,11 @@ describe('SubtestsResultsView Component Tests for mann-whitney-u testVersion', (
await setupForSorting({ extraParameters: 'sort=delta' });
await screen.findByText('dhtml.html');
expect(summarizeVisibleRows('mann-whitney-u')).toEqual([
'regression.html: 0.12, Significant, 25.00%',
'improvement.html: -0.05, Significant, 50.00%',
'browser.html: -0.04, Not significant, 15.00%',
'dhtml.html: 0.02, Significant, 60.00%',
'tablemutation.html: 0.01, -, 45.00%',
'regression.html: 0.12, 25.00%',
'improvement.html: -0.05, 50.00%',
'browser.html: -0.04, 15.00%',
'dhtml.html: 0.02, 60.00%',
'tablemutation.html: 0.01, 45.00%',
]);
// It should have the "descending" SVG.
expect(screen.getByRole('button', { name: /Delta/ })).toMatchSnapshot();
Expand All @@ -640,11 +610,11 @@ describe('SubtestsResultsView Component Tests for mann-whitney-u testVersion', (
it('initializes the sort from the URL at load time for a descending sort', async () => {
await setupForSorting({ extraParameters: 'sort=delta|desc' });
expect(summarizeVisibleRows('mann-whitney-u')).toEqual([
'regression.html: 0.12, Significant, 25.00%',
'improvement.html: -0.05, Significant, 50.00%',
'browser.html: -0.04, Not significant, 15.00%',
'dhtml.html: 0.02, Significant, 60.00%',
'tablemutation.html: 0.01, -, 45.00%',
'regression.html: 0.12, 25.00%',
'improvement.html: -0.05, 50.00%',
'browser.html: -0.04, 15.00%',
'dhtml.html: 0.02, 60.00%',
'tablemutation.html: 0.01, 45.00%',
]);
// It should have the "descending" SVG.
expect(screen.getByRole('button', { name: /Delta/ })).toMatchSnapshot();
Expand Down
7 changes: 2 additions & 5 deletions src/__tests__/CompareResults/SubtestsRevisionRow.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ describe('SubtestsRevisionRow Component', () => {
expect(newMean).toHaveTextContent('982.41');
});

it('should display cliffs delta, significance, and effects size in subtests for mann-whitney-u testVersion', async () => {
it('should display cliffs delta and effects size in subtests for mann-whitney-u testVersion', async () => {
const { subtestsMannWhitneyResult } = getTestData();
const mockGridTemplateColumns = '1fr 1fr 1fr 1fr 1fr 1fr 1fr 1fr';
renderWithRoute(
Expand All @@ -188,12 +188,9 @@ describe('SubtestsRevisionRow Component', () => {
);

const roles = await screen.findAllByRole('cell');
const effects = roles[7]?.childNodes[0];
const effects = roles[6]?.childNodes[0];
expect(effects).toHaveTextContent('60.00%');

const significance = roles[6]?.childNodes[0];
expect(significance).toHaveTextContent('Significant');

const cliffs_delta = roles[5]?.childNodes[1];
expect(cliffs_delta).toHaveTextContent('0.02');
});
Expand Down
Loading