Skip to content
This repository was archived by the owner on Jan 29, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions data/experiment-recipe-samples/mobile-a-a.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"schemaVersion": "0.1.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly can't imagine us using the patch version for anything useful, but I also have no objection to having it here, so 👍

"id": "mobile-a-a-example",
"slug": "mobile-a-a-example",
"application": "reference-browser",
Expand Down
1 change: 1 addition & 0 deletions data/experiment-recipe-samples/pull-factor.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"schemaVersion": "0.1.0",
"id": "message-aboutwelcome-pull-factor-reinforcement",
"slug": "message-aboutwelcome-pull-factor-reinforcement",
"application": "firefox-desktop",
Expand Down
43 changes: 1 addition & 42 deletions test/test-experiment-recipe-firefox.ts
Original file line number Diff line number Diff line change
@@ -1,47 +1,6 @@
import { typeGuards } from "..";
import { assert } from "chai";

const TEST_EXPERIMENT = {
id: "bug-1637316-message-aboutwelcome-pull-factor-reinforcement-76-rel-release-76-77",
slug: "bug-1637316-message-aboutwelcome-pull-factor-reinforcement-76-rel-release-76-77",
application: "firefox-desktop",
userFacingName: "About:Welcome Pull Factor Reinforcement",
userFacingDescription:
"4 branch experiment different variants of about:welcome with a goal of testing new experiment framework and get insights on whether reinforcing pull-factors improves retention. Test deployment of multiple branches using new experiment framework",
isEnrollmentPaused: true,
bucketConfig: {
randomizationUnit: "normandy_id",
namespace: "bug-1637316-message-aboutwelcome-pull-factor-reinforcement-76-rel-release-76-77",
start: 0,
count: 2000,
total: 10000,
},
startDate: null,
endDate: null,
proposedEnrollment: 7,
referenceBranch: "control",
probeSets: [],
branches: [
{
slug: "control",
ratio: 1,
feature: {
featureId: "cfr",
enabled: true,
value: null,
},
},
{
slug: "treatment-variation-b",
ratio: 1,
feature: {
featureId: "cfr",
enabled: true,
value: null,
},
},
],
};
import TEST_EXPERIMENT from "../data/experiment-recipe-samples/pull-factor.json";

describe("experiment schemas", () => {
it("should validate an existing onboarding experiment", async () => {
Expand Down
3 changes: 2 additions & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"module": "CommonJS",
"strict": true,
"target": "ES2018",
"esModuleInterop": true
"esModuleInterop": true,
"resolveJsonModule": true
}
}
5 changes: 5 additions & 0 deletions types/experiments.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@
* 2. Jetstream via the Experimenter API
*/
export interface NimbusExperiment {
/**
* Version of the NimbusExperiment schema this experiment refers to
*/
schemaVersion: string;

/** Unique identifier for the experiment */
slug: string;

Expand Down