refactor: replace if/elif chain with match/case in datetime formatting

[marcosppca]

Summary

This pull request refactors the date and time formatting logic to use Python’s structural pattern matching (match/case, PEP 634) instead of multiple if/elif statements.
The new implementation improves readability and maintainability while preserving all existing behavior and localization rules.

Motivation

The original function handled several format types (shortdatetime, longdatetime, date, time, datetime, year, etc.) using a long chain of conditional statements.
By switching to match/case, the control flow becomes clearer and easier to extend, making each format explicitly defined and simplifying future maintenance.

Changes

• Replaced the if/elif chain with a match format: statement.
• Preserved all existing cases (shortdatetime, shortdate, longdatetime, date, time, datetime, year).
• Maintained support for “today” detection when format is shortdatetime or shortdate.
• Kept localization (locale) and timezone (tzinfo) behavior identical to the previous implementation.
• Raised DateTimeFormatError for unsupported formats, same as before.

Example

match format:
    case "shortdatetime" | "shortdate":
        today = datetime.datetime.now(tz=convert_tzinfo).toordinal()
        kwargs = {"format": "short", "tzinfo": convert_tzinfo, "locale": locale}
        if convert_value.toordinal() == today:
            formatted = _lazy("Today at %s") % format_time(convert_value, **kwargs)
        elif format == "shortdatetime":
            formatted = format_datetime(convert_value, **kwargs)
        else:
            del kwargs["tzinfo"]
            formatted = format_date(convert_value, **kwargs)

    case "longdatetime":
        formatted = format_datetime(
            convert_value, format="long", tzinfo=convert_tzinfo, locale=locale
        )

    case "date":
        formatted = format_date(convert_value, locale=locale)

    case "time":
        formatted = format_time(convert_value, tzinfo=convert_tzinfo, locale=locale)

    case "datetime":
        formatted = format_datetime(convert_value, tzinfo=convert_tzinfo, locale=locale)

    case "year":
        formatted = format_datetime(
            convert_value, format="yyyy", tzinfo=convert_tzinfo, locale=locale
        )

    case _:
        raise DateTimeFormatError

[Copilot]

Pull Request Overview

This PR refactors the datetimeformat function in jinja_helpers.py to use Python 3.10+ match-case syntax instead of traditional if-elif-else statements, improving code readability and maintainability.

Key Changes

• Replaced if-elif-else chain with match-case statement for format string handling
• Maintained functional equivalence with the original implementation
• Added pattern matching with the | operator for "shortdatetime" and "shortdate" cases

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Extra blank line added. While not a functional issue, this adds unnecessary whitespace. Consider removing this blank line to maintain consistency with the other case branches (lines 298, 301, 304, 307) which don't have trailing blank lines.

Suggested change

[akatsoulas]

Thanks for this PR! Regarding this helper method wouldn't be simpler if this call was

value_date = convert_value.date()

The edge cases that the as_date_in_tz function checks for have been handled in earlier steps. For example the check for Date objects is defined in line 248