[ci breaking-change] feat: configurable memory requests; change default from 16GiB to 19GB#3218
Merged
Conversation
mikewilli
force-pushed
the
cluster-memory-requests
branch
from
9fe4d24 to
2d18daf
Compare
mikewilli
force-pushed
the
cluster-memory-requests
branch
from
2d18daf to
019a2d1
Compare
scholtzan
approved these changes
May 22, 2026
Collaborator
scholtzan
left a comment
scholtzan
left a comment
There was a problem hiding this comment.
Tests need updating but other than that looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our current default of 16GiB has always left nodes underutilized because this translates to around 50GB of the ~61.5GB available. If we request 19GB, that means 19.89GB on the node gets reserved, so we can still fit 3 pods on each node, but won't be wasting >10GB of unused memory.
This also makes the memory requested an Argo workflow parameter, and is configurable via a CLI parameter, in case we want to make this more dynamic in the future.
[ci breaking-change]because this PR changes the Argo workflow template.