Conversation
travis79
force-pushed
the
Bug2020962-Session-Impl
branch
from
79101f5 to
5105cfa
Compare
badboy
requested changes
Apr 27, 2026
badboy
requested changes
Apr 28, 2026
Member
badboy
left a comment
badboy
left a comment
There was a problem hiding this comment.
one question, otherwise this is very mechanic additions to support the Glean changes
Add support for the `in_session` boolean field on metric definitions. When `in_session: true` is set on an event metric, the parser sets `out_of_session: false` on the metric object for code generation. - Schema: add `in_session` property to metrics 2-0-0 schema with a validation rule that rejects `in_session: true` on non-event types - Model: Event.__init__ pops `in_session` and sets `out_of_session`; Event.serialize strips `out_of_session` so it doesn't round-trip back into YAML validation - Util: add `out_of_session` to `common_metric_args` so Kotlin, Swift, and JavaScript templates pick it up automatically via their existing iteration over that list
The Rust template hardcodes CommonMetricData fields rather than iterating common_metric_args like Kotlin/Swift/JS, so it needs an explicit addition to emit `out_of_session` when defined.
- Model tests: verify in_session on events sets out_of_session, default omits it, non-event with in_session: true is rejected, non-event with in_session: false is accepted - Output tests: verify generated Rust, Kotlin, and Swift code contains outOfSession/out_of_session when in_session: true - Test data: add in_session: true to the event in all_metrics.yaml
travis79
force-pushed
the
Bug2020962-Session-Impl
branch
from
104d62f to
2a4c166
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
make testruns without emitting any warningsmake lintruns without emitting any errorsCHANGELOG.mdor an explanation of why it does not need one