Skip to content

fix(payments-next): UpgradeCartFromOfferingConfigIdMissingError: from OfferingConfigId not present for upgrade cart#20643

Open
elizabeth-ilina wants to merge 1 commit into
mainfrom
PAY-3705-upgrade-cart-from-offering-config-id-missing-error
Open

fix(payments-next): UpgradeCartFromOfferingConfigIdMissingError: from OfferingConfigId not present for upgrade cart#20643
elizabeth-ilina wants to merge 1 commit into
mainfrom
PAY-3705-upgrade-cart-from-offering-config-id-missing-error

Conversation

@elizabeth-ilina
Copy link
Copy Markdown
Contributor

@elizabeth-ilina elizabeth-ilina commented May 25, 2026

Because

  • If customer goes through the upgrade flow and lands on the success page then navigates back to start, the cart will be missing the fromOfferingConfigId, throwing an error and showing the "something went wrong" page.

This pull request

  • Uses getCartOrRedirectAction instead of getCartAction in [locale]/[offeringId]/[interval]/upgrade/[cartId]/(startLayout)/layout.tsx

Issue that this pull request solves

Closes #PAY-3705

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).
  • I have manually reviewed all AI generated code.

How to review (Optional)

STRs:

  1. Subscribe to (for example) VPN monthly.
  2. Upgrade (successfully) to yearly.
  3. Either: press the 'back' arrow from the success page, OR, edit the URL to be start instead of success (both videos attached).

In Stage, pressing the 'back' arrow:

Screen.Recording.2026-05-25.at.11.05.17.AM.mov

Or, editing the URL:

Screen.Recording.2026-05-25.at.11.49.50.AM.mov

After fix:

Screen.Recording.2026-05-25.at.11.51.45.AM.mov
  • Key files/areas to focus on:
  • Suggested review order:
  • Risky or complex parts:

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

…OfferingConfigId not present for upgrade cart

Because:

* If customer goes through the upgrade flow and lands on the success page then navigates back to start, the cart will be missing the fromOfferingConfigId, throwing an error and showing the "something went wrong" page.

This commit:

* Uses getCartOrRedirectAction instead of getCartAction in [locale]/[offeringId]/[interval]/upgrade/[cartId]/(startLayout)/layout.tsx

Closes #[PAY-3705](https://mozilla-hub.atlassian.net/browse/PAY-3705)
@elizabeth-ilina elizabeth-ilina marked this pull request as ready for review May 26, 2026 13:09
@elizabeth-ilina elizabeth-ilina requested a review from a team as a code owner May 26, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant