Conversation
vpomerleau
reviewed
May 26, 2026
| - vzare@mozilla.com | ||
| - fxa-staff@mozilla.com | ||
| bugs: | ||
| - https://mozilla-hub.atlassian.net/browse/FXA-7265 |
Contributor
There was a problem hiding this comment.
This should be FXA-13719 (ditto for other new events here)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Firefox Accounts Settings Glean instrumentation for the linked-passwordless “alternative auth options” view, ensuring a non-cached view event is recorded and adding missing “start” events when users click Apple/Google from that view. It also removes the legacy third_party_auth.login_no_pw_view metric in favor of the new login.alternative_auth_* funnel.
Changes:
- Add new Glean events under
login.*:alternative_auth_view,alternative_auth_google_start,alternative_auth_apple_start. - Update
SigninAlternativeAuthOptionsto recordlogin.alternativeAuthView(and stop emitting the prior cached/TPA view events). - Record the new “start” events from
ThirdPartyAuthwhen used in the alternative-auth view; update the Glean bridge and unit tests accordingly.
Reviewed changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/fxa-shared/metrics/glean/web/account.ts | Regenerated header (glean_parser version bump). |
| packages/fxa-shared/metrics/glean/web/accountBanner.ts | Regenerated header (glean_parser version bump). |
| packages/fxa-shared/metrics/glean/web/accountPref.ts | Regenerated header (glean_parser version bump). |
| packages/fxa-shared/metrics/glean/web/cachedLogin.ts | Regenerated header (glean_parser version bump). |
| packages/fxa-shared/metrics/glean/web/cad.ts | Regenerated header (glean_parser version bump). |
| packages/fxa-shared/metrics/glean/web/cadApproveDevice.ts | Regenerated header (glean_parser version bump). |
| packages/fxa-shared/metrics/glean/web/cadFirefox.ts | Regenerated header (glean_parser version bump). |
| packages/fxa-shared/metrics/glean/web/cadMobilePair.ts | Regenerated header (glean_parser version bump). |
| packages/fxa-shared/metrics/glean/web/cadMobilePairUseApp.ts | Regenerated header (glean_parser version bump). |
| packages/fxa-shared/metrics/glean/web/cadRedirectDesktop.ts | Regenerated header (glean_parser version bump). |
| packages/fxa-shared/metrics/glean/web/cadRedirectMobile.ts | Regenerated header (glean_parser version bump). |
| packages/fxa-shared/metrics/glean/web/deleteAccount.ts | Regenerated header (glean_parser version bump). |
| packages/fxa-shared/metrics/glean/web/email.ts | Regenerated header (glean_parser version bump). |
| packages/fxa-shared/metrics/glean/web/entrypoint.ts | Regenerated header (glean_parser version bump). |
| packages/fxa-shared/metrics/glean/web/error.ts | Regenerated header (glean_parser version bump). |
| packages/fxa-shared/metrics/glean/web/event.ts | Regenerated header + import reordering from generator. |
| packages/fxa-shared/metrics/glean/web/index.ts | Update generated eventsMap to add new login events and remove loginNoPwView. |
| packages/fxa-shared/metrics/glean/web/login.ts | Add generated login.alternative_auth_* event metrics. |
| packages/fxa-shared/metrics/glean/web/passwordReset.ts | Regenerated header (glean_parser version bump). |
| packages/fxa-shared/metrics/glean/web/pings.ts | Regenerated header (glean_parser version bump). |
| packages/fxa-shared/metrics/glean/web/promoQrMobile.ts | Regenerated header (glean_parser version bump). |
| packages/fxa-shared/metrics/glean/web/reg.ts | Regenerated header (glean_parser version bump). |
| packages/fxa-shared/metrics/glean/web/relyingParty.ts | Regenerated header (glean_parser version bump). |
| packages/fxa-shared/metrics/glean/web/session.ts | Regenerated header (glean_parser version bump). |
| packages/fxa-shared/metrics/glean/web/thirdPartyAuth.ts | Remove generated loginNoPwView metric definition. |
| packages/fxa-shared/metrics/glean/web/thirdPartyAuthSetPassword.ts | Regenerated header (glean_parser version bump). |
| packages/fxa-shared/metrics/glean/web/utm.ts | Regenerated header (glean_parser version bump). |
| packages/fxa-shared/metrics/glean/fxa-ui-metrics.yaml | Define new login.alternative_auth_* events and remove third_party_auth.login_no_pw_view. |
| packages/fxa-settings/src/components/ThirdPartyAuth/index.tsx | Emit new login start events for Google/Apple when used in the alternative-auth view. |
| packages/fxa-settings/src/lib/glean/index.ts | Route new event names to the generated login event metrics; remove old TPA view event routing. |
| packages/fxa-settings/src/lib/glean/index.test.ts | Add tests for the new login alternative-auth events; remove obsolete test for loginNoPwView. |
| packages/fxa-settings/src/pages/Signin/index.test.tsx | Update mocks/assertions to reflect new alternative-auth view event ownership. |
| packages/fxa-settings/src/pages/Signin/components/SigninAlternativeAuthOptions/index.tsx | Change view name and emit login.alternativeAuthView on mount instead of cached/TPA view events. |
| packages/fxa-settings/src/pages/Signin/components/SigninAlternativeAuthOptions/index.test.tsx | Update test to assert login.alternativeAuthView is emitted on mount. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ | ||
|
|
||
| // AUTOGENERATED BY glean_parser v19.0.0. DO NOT EDIT. DO NOT COMMIT. | ||
| // AUTOGENERATED BY glean_parser v19.1.0. DO NOT EDIT. DO NOT COMMIT. |
Comment on lines
+157
to
+162
| case 'google-signin-alternative-auth': | ||
| GleanMetrics.login.alternativeAuthGoogleStart(); | ||
| break; | ||
| case 'apple-signin-alternative-auth': | ||
| GleanMetrics.login.alternativeAuthAppleStart(); | ||
| break; |
Contributor
Author
There was a problem hiding this comment.
I'll add these today. I did test them manually.
Because: * We are missing 'start' events on third party auth buttons, for users in this view * This state was using a 'cached' view event, and it is not a 'cached' page This commit: * Updates the SigninAlternativeAuthOptions 'view' event * Adds new events for alternative auth third party auth button start closes FXA-13719
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
This commit:
closes FXA-13719