feat: add new strapi customization for user expectation on the final authentication screens #19959
Conversation
|
PR for strapi: mozilla/fxa-strapi#161 |
| /> | ||
| ); | ||
|
|
||
| export const OAuthDesktopServiceRelay = () => ( |
There was a problem hiding this comment.
We may want to swap this with a story that shows the page with additionalAccessibilityInfo
There was a problem hiding this comment.
The DefaultWithCms one contains additionalAccessibilityInfo
| sign in. | ||
| </p> | ||
| </FtlMsg> | ||
| {additionalAccessibilityInfo && ( |
There was a problem hiding this comment.
Is the design changing to show the info in a banner on all pages? Here it was previously a regular paragraph.
There was a problem hiding this comment.
Oops! I copy and pasted 😅
| sign in. | ||
| </p> | ||
| </FtlMsg> | ||
| {additionalAccessibilityInfo && ( |
There was a problem hiding this comment.
Same question here about the switch from a paragraph to a banner. (this applies to multiple pages, but I won't comment on all)
| </AppContext.Provider> | ||
| ); | ||
|
|
||
| export const OAuthDesktopServiceRelay = () => ( |
There was a problem hiding this comment.
Same comment as before, for all stories - we should make sure that all pages have a story with the additional accessibility info so we can ensure the styling looks as expected.
| recoveryKeyExists, | ||
| integrationIsSync, | ||
| isFirefoxClientServiceRelay, | ||
| additionalAccessibilityInfo, |
There was a problem hiding this comment.
This page differs from the others in passing the text as a prop instead of retrieving cmsInfo in index.tsx
There was a problem hiding this comment.
This page doesn't have integration passed in, but yeah I probably should keep it consistent
MagentaManifold
force-pushed
the
FXA-12638
branch
from
0d3f37a to
ae7ed86
Compare
…authentication screens Because: * we want to customize "Firefox will try sending you back to use an email mask after you sign in." because we need something similar for smart window This commit: * adds additionalAccessibilityInfo (name suggested by Ross) to cmsInfo.shared Closes FXA-12638
MagentaManifold
force-pushed
the
FXA-12638
branch
from
ae7ed86 to
533a110
Compare
Because
This pull request
Issue that this pull request solves
Closes: FXA-12638
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.