feat(auth): Use libs email in auth server #19952
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschom
reviewed
Jan 27, 2026
| ...FxaMailerFormat.localTime(request), | ||
| ...FxaMailerFormat.location(request), | ||
| ...FxaMailerFormat.device(request), | ||
| code: 'todo', |
Contributor
There was a problem hiding this comment.
Don't forget to provide these!
Contributor
There was a problem hiding this comment.
Are redirect to and service needed?
dschom
reviewed
Jan 27, 2026
| ...FxaMailerFormat.location(request), | ||
| ...FxaMailerFormat.device(request), | ||
| ...FxaMailerFormat.sync(false), | ||
| code: 'SEC456', |
Contributor
There was a problem hiding this comment.
Don't forget to provide actual code!
dschom
reviewed
Jan 27, 2026
| ...FxaMailerFormat.location(request), | ||
| ...FxaMailerFormat.device(request), | ||
| code: emailCode, | ||
| resume, |
Contributor
There was a problem hiding this comment.
Are redirectTo & service needed? I see they are provided in the original implementation?
Contributor
Author
There was a problem hiding this comment.
Very likely! I didn't see them on the underlying type but I'll update that if needed
dschom
reviewed
Jan 27, 2026
| clientName: 'Firefox', | ||
| redirectTo: 'https://example.com', | ||
| resume: 'resumeToken', | ||
| }); |
Contributor
There was a problem hiding this comment.
Is service needed? I see it's provided in the original data.
dschom
reviewed
Jan 27, 2026
dschom
reviewed
Jan 27, 2026
| mockFxaMailer.sendVerifyEmail.callCount, | ||
| 0, | ||
| 'mailer.sendVerifyEmail was not called' | ||
| 'mockFxaMailer.sendVerifyEmail was called' |
Contributor
Author
There was a problem hiding this comment.
Good call - I was fixing some of them since they weren't right and just mixed this one up
nshirley
force-pushed
the
FXA-12883
branch
2 times, most recently
from
b6e02d5 to
4db63fd
Compare
Because: - We've moved email sending and rendering out of auth-server This Commit: - Updates several emails to send using the new fxa-mailer, renderer and sender Closes: FXA-12883
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This Commit:
Closes: FXA-12883
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.