fix(settings): fix password reset with relay integration #19925
+196
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MagentaManifold
force-pushed
the
FXA-12814
branch
2 times, most recently
from
a7324a8 to
3fb8572
Compare
LZoog
approved these changes
Jan 26, 2026
Contributor
LZoog
left a comment
LZoog
left a comment
There was a problem hiding this comment.
Makes sense that we need this logic, thanks!
|
|
||
| expect(mockAlertBar.success).toHaveBeenCalledWith( | ||
| 'Your password has been reset' | ||
| ); |
Contributor
There was a problem hiding this comment.
Just a nit: could we test that services: { relay: {} } is sent into firefox.fxaLoginSignedInUser?
edit: alternatively, we could add a reset password test on the playwright tests just merged here for this flow: #19944
MagentaManifold
force-pushed
the
FXA-12814
branch
from
3fb8572 to
6d9d0ab
Compare
Because: * it doesn't send user back to where they were This commit: * fixes this by sending the webchannel message Closes FXA-12814
MagentaManifold
force-pushed
the
FXA-12814
branch
from
6d9d0ab to
36da5f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-12814
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
The container doesn't have unit tests. Should we add some?