Skip to content

fix(nimbus): hide weekly metrics from displaying on results page popout card if not available #14261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
moibra05 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(nimbus): hide weekly metrics from displaying on results page popout card if not available #14261

moibra05 wants to merge 1 commit into from
+220 −58

Conversation

@moibra05
Copy link
Contributor

@moibra05 moibra05 commented Dec 31, 2025

Because

  • The current new results page ui assumes that all metrics contain weekly data which is not true. This results in empty "Weekly breakdown" sections that serve no purpose.

This commit

  • Conditionally renders the "Weekly breakdown" component if the specific metric supports weekly results

Fixes #14257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaredlockhart jaredlockhart Awaiting requested review from jaredlockhart jaredlockhart is a code owner

@yashikakhurana yashikakhurana Awaiting requested review from yashikakhurana yashikakhurana is a code owner

@freshstrangemusic freshstrangemusic Awaiting requested review from freshstrangemusic freshstrangemusic is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

pr-preview

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Weekly metrics card appearing when empty

2 participants

@moibra05