Added initial tests for repository._transform.#4404
Open
flowejam wants to merge 1 commit intomozilla:masterfrom
Open
Added initial tests for repository._transform.#4404flowejam wants to merge 1 commit intomozilla:masterfrom
flowejam wants to merge 1 commit intomozilla:masterfrom
Conversation
Also added comments re. failed tests for repository._transform.
Member
suhaibmujahid
left a comment
There was a problem hiding this comment.
Thank you for your contribution, @flowejam!
The tests are failing! Could you please fix that?
Author
Thanks @suhaibmujahid ! Apologies if I'm missing something here, but from the log it looks like the only test that is failing is the one I added - I've included a snippet below. I think there could be an issue with the way tests are detected? E.g. for bugbug, tests are in a folder called 'tests' in the main directory of the repo, but wouldn't they be missed by this function (repository.is_test)?: |
Author
|
@suhaibmujahid @marco-c just thought I'd follow up - any chance of getting another look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added comments re. failed tests for repository._transform.
This is for #384