Skip to content

Bug 2038168 - fix version override for ohttp#7363

Merged
mhammond merged 1 commit into
mozilla:mainfrom
mhammond:push-vwtwxklutkxz
May 13, 2026
Merged

Bug 2038168 - fix version override for ohttp#7363
mhammond merged 1 commit into
mozilla:mainfrom
mhammond:push-vwtwxklutkxz

Conversation

@mhammond
Copy link
Copy Markdown
Member

I used 'revision' instead of 'rev' - and I'm fairly sure that kinda worked, because otherwise ohttp wouldn't have built here.

I'm a little confused by the Cargo.lock changes though, you can see the format of the ohttp entry changed, even though both formats have the same revision. It now also takes the earlier toml version even though it is marked as compatible 0.9

But it seems to work and this is obviously correct.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@mhammond mhammond requested a review from bendk May 12, 2026 06:55
I used 'revision' instead of 'rev' - and I'm fairly sure that kinda
worked, because otherwise ohttp wouldn't have built here.

I'm a little confused by the Cargo.lock changes though, you can see
the format of the ohttp entry changed, even though both formats have
the same revision. It now also takes the earlier toml version even
though it is marked as compatible 0.9

But it seems to work and this is obviously correct.
@mhammond mhammond force-pushed the push-vwtwxklutkxz branch from a91cfff to ebc6da5 Compare May 12, 2026 07:17
Copy link
Copy Markdown
Contributor

@bendk bendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those Cargo.lock changes are really weird, but this does seem obviously correct.

@mhammond mhammond added this pull request to the merge queue May 13, 2026
Merged via the queue into mozilla:main with commit 06c391e May 13, 2026
15 checks passed
@mhammond mhammond deleted the push-vwtwxklutkxz branch May 13, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants