Skip to content

remove Rust "gecko" features from nss. [ci full]#7260

Open
mhammond wants to merge 1 commit intomozilla:mainfrom
mhammond:push-ovtnpzxsnuwv
Open

remove Rust "gecko" features from nss. [ci full]#7260
mhammond wants to merge 1 commit intomozilla:mainfrom
mhammond:push-ovtnpzxsnuwv

Conversation

@mhammond
Copy link
Member

@mhammond mhammond commented Mar 6, 2026

It's not actually enabled for desktop, so just adds confusion. It appears as though it was previously needed before lib_sqlite3 grew its own set of features to control how sqlite is linked.

(I'm fairly sure this isn't going to break desktop, but headsup @rvandermeulen @DonalMe @dsmithpadilla - if the m-c bump does end up failing for nss/sqlite looking reasons, this will be the reason!)

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

It's not actually enabled for desktop, so just adds confusion. It appears as
though it was previously needed before lib_sqlite3 grew its own set of features
to control how sqlite is linked.
@mhammond mhammond requested review from bendk and ncalexan March 6, 2026 00:45
@mhammond
Copy link
Member Author

mhammond commented Mar 6, 2026

/taskcluster ci full

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant