Report error if session token is not present in complete_oauth_flow#7259
Open
bendk wants to merge 1 commit intomozilla:mainfrom
Open
Report error if session token is not present in complete_oauth_flow#7259bendk wants to merge 1 commit intomozilla:mainfrom
complete_oauth_flow#7259bendk wants to merge 1 commit intomozilla:mainfrom
Conversation
We've been getting a bunch of `No stored session token` error reports and have been discussing this on slack. My theory is that somehow the oauth flow is completing without a session token. Maybe because the `set_user_data` is coming after the `complete_oauth_flow` call. This tries to validate that theory by reporting errors when `complete_oauth_flow` is called without a session token. Note that this won't lead always lead to the error state if `set_user_data` is called shortly after. However it could, for example if some exception prevents the `set_user_data` call, or Firefox exits early.
mhammond
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been getting a bunch of
No stored session tokenerror reports and have been discussing this on slack. My theory is that somehow the oauth flow is completing without a session token. Maybe because theset_user_datais coming after thecomplete_oauth_flowcall.This tries to validate that theory by reporting errors when
complete_oauth_flowis called without a session token. Note that this won't lead always lead to the error state ifset_user_datais called shortly after. However it could, for example if some exception prevents theset_user_datacall, or Firefox exits early.Pull Request checklist
[ci full]to the PR title.