Bug 2021137 - Fix Loop in Nimbus Gecko Preferences Project#7258
Merged
freshstrangemusic merged 1 commit intomozilla:mainfrom Mar 5, 2026
Merged
Bug 2021137 - Fix Loop in Nimbus Gecko Preferences Project#7258freshstrangemusic merged 1 commit intomozilla:mainfrom
freshstrangemusic merged 1 commit intomozilla:mainfrom
Conversation
Using `self.end_initialize(db, writer, &mut state)?;` instead of `writer.commit()?;` caused a loop with Android of: register_previous_gecko_pref_states -> commit_and_update -> map_gecko_prefs_to_enrollment_slugs_and_update_store -> set_gecko_prefs_state -> setGeckoPrefsState-> nimbusApi!!.registerPreviousGeckoPrefStates -> This patch adjusts it to a simple commit.
freshstrangemusic
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
self.end_initialize(db, writer, &mut state)?;instead ofwriter.commit()?;caused a loop with Android of: register_previous_gecko_pref_states ->commit_and_update ->
map_gecko_prefs_to_enrollment_slugs_and_update_store -> set_gecko_prefs_state ->
setGeckoPrefsState->
nimbusApi!!.registerPreviousGeckoPrefStates ->
This patch adjusts it to a simple commit.
Pull Request checklist
[ci full]to the PR title.