Skip to content

Bug 2021137 - Fix Loop in Nimbus Gecko Preferences Project#7258

Merged
freshstrangemusic merged 1 commit intomozilla:mainfrom
ohall-m:main
Mar 5, 2026
Merged

Bug 2021137 - Fix Loop in Nimbus Gecko Preferences Project#7258
freshstrangemusic merged 1 commit intomozilla:mainfrom
ohall-m:main

Conversation

@ohall-m
Copy link
Contributor

@ohall-m ohall-m commented Mar 5, 2026

Using self.end_initialize(db, writer, &mut state)?; instead of writer.commit()?; caused a loop with Android of: register_previous_gecko_pref_states ->
commit_and_update ->
map_gecko_prefs_to_enrollment_slugs_and_update_store -> set_gecko_prefs_state ->
setGeckoPrefsState->
nimbusApi!!.registerPreviousGeckoPrefStates ->

This patch adjusts it to a simple commit.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Using `self.end_initialize(db, writer, &mut state)?;` instead of
`writer.commit()?;` caused a loop with Android of:
register_previous_gecko_pref_states ->
commit_and_update ->
map_gecko_prefs_to_enrollment_slugs_and_update_store ->
set_gecko_prefs_state ->
setGeckoPrefsState->
nimbusApi!!.registerPreviousGeckoPrefStates ->

This patch adjusts it to a simple commit.
@ohall-m ohall-m added the nimbus Nimbus, the experimentation platform. label Mar 5, 2026
@freshstrangemusic freshstrangemusic added this pull request to the merge queue Mar 5, 2026
Merged via the queue into mozilla:main with commit e2fc28f Mar 5, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

nimbus Nimbus, the experimentation platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants