Add get_session_token_if_present method#7257
Closed
bendk wants to merge 1 commit intomozilla:mainfrom
Closed
Conversation
We're seeing lots of Android errors related to messing session tokens (https://bugzilla.mozilla.org/show_bug.cgi?id=2007418). However, it's not clear that Android really cares about the session token, see the bug. Let's add a method that returns an optional string rather than throwing and switch Android to using this method. This matches the way they want to get session tokens, since they just catch any errors and return null anyway.
Contributor
Author
|
After talking this through on Slack, it seems like the session token is expected to be present and it should be an error when it's not. I'm going to close this one and try to figure out how we can ensure that the session token is always there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're seeing lots of Android errors related to messing session tokens (https://bugzilla.mozilla.org/show_bug.cgi?id=2007418). However, it's not clear that Android really cares about the session token, see the bug.
Let's add a method that returns an optional string rather than throwing and switch Android to using this method. This matches the way they want to get session tokens, since they just catch any errors and return null anyway.
Pull Request checklist
[ci full]to the PR title.