Merged
Conversation
bendk
requested review from
a team,
lougeniaC64 and
skhamis
and removed request for
lougeniaC64
Contributor
Author
|
I've harassed Lougenia too much with these dashboard generator PRs. I'm going to spread the work some and give this one to Sammy. |
bendk
force-pushed
the
push-kutvxrwusqyy
branch
from
ace3f28 to
8141c1e
Compare
Contributor
Author
|
Here's the results on the DISCO dashboard: https://yardstick.mozilla.org/d/disco-main/disco |
* Use unit field from standard options, rather than putting units in the label * Make histogram graphs logarithmic. * Split up labeled distribution panels into nightly/beta/release.
skhamis
approved these changes
Mar 4, 2026
Contributor
skhamis
left a comment
skhamis
left a comment
There was a problem hiding this comment.
Great changes! One comment super nit that you can just ignore, LGTM!
| /// Name to display on the dashboard | ||
| pub display_name: &'static str, | ||
| /// Label describing what we're measure, including units | ||
| /// Label describing what we're measure |
| /// Name to display on the dashboard | ||
| pub display_name: &'static str, | ||
| /// Label describing what we're measure, including units | ||
| /// Label describing what we're measure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
[ci full]to the PR title.