Bug 2019091 - Reset Nimbus databases that are on v1#7243
Draft
freshstrangemusic wants to merge 1 commit intomainfrom
Draft
Bug 2019091 - Reset Nimbus databases that are on v1#7243freshstrangemusic wants to merge 1 commit intomainfrom
freshstrangemusic wants to merge 1 commit intomainfrom
Conversation
There was previously a bug where Nimbus databases that were stuck at v1 would mistakenly only ever update to v2 but then write that they were v3 to their database, preventing them from ever migrating correctly to v3. This is unlikely to happen because the migration from v1 to v2 was 5 years ago, so a client would have to have been installed but unused for that entire period. In light of this, we are removing the v1 to v2 migration and resetting all databases that are < v2. This is unlikely to affect any real users. This does not fix the general case issue if we added an additional migration (i.e., v3 to v4), but that will be resolved in bug 1997631, which is refactoring the migration system and adding telemetry.
relud
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was previously a bug where Nimbus databases that were stuck at v1 would mistakenly only ever update to v2 but then write that they were v3 to their database, preventing them from ever migrating correctly to v3. This is unlikely to happen because the migration from v1 to v2 was 5 years ago, so a client would have to have been installed but unused for that entire period.
In light of this, we are removing the v1 to v2 migration and resetting all databases that are < v2. This is unlikely to affect any real users.
This does not fix the general case issue if we added an additional migration (i.e., v3 to v4), but that will be resolved in bug 1997631, which is refactoring the migration system and adding telemetry.
Pull Request checklist
[ci full]to the PR title.