Skip to content

Comments

Bug 2019091 - Reset Nimbus databases that are on v1#7243

Draft
freshstrangemusic wants to merge 1 commit intomainfrom
freshstrangemusic/push-rkxvxunyqnnm
Draft

Bug 2019091 - Reset Nimbus databases that are on v1#7243
freshstrangemusic wants to merge 1 commit intomainfrom
freshstrangemusic/push-rkxvxunyqnnm

Conversation

@freshstrangemusic
Copy link
Member

There was previously a bug where Nimbus databases that were stuck at v1 would mistakenly only ever update to v2 but then write that they were v3 to their database, preventing them from ever migrating correctly to v3. This is unlikely to happen because the migration from v1 to v2 was 5 years ago, so a client would have to have been installed but unused for that entire period.

In light of this, we are removing the v1 to v2 migration and resetting all databases that are < v2. This is unlikely to affect any real users.

This does not fix the general case issue if we added an additional migration (i.e., v3 to v4), but that will be resolved in bug 1997631, which is refactoring the migration system and adding telemetry.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

There was previously a bug where Nimbus databases that were stuck at v1
would mistakenly only ever update to v2 but then write that they were v3
to their database, preventing them from ever migrating correctly to v3.
This is unlikely to happen because the migration from v1 to v2 was 5
years ago, so a client would have to have been installed but unused for
that entire period.

In light of this, we are removing the v1 to v2 migration and resetting
all databases that are < v2. This is unlikely to affect any real users.

This does not fix the general case issue if we added an additional
migration (i.e., v3 to v4), but that will be resolved in bug 1997631,
which is refactoring the migration system and adding telemetry.
@freshstrangemusic freshstrangemusic marked this pull request as draft February 25, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants