Skip to content

Patch missing NSS symbols for iOS x86_64 simulators #7242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
issammani wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −0
Open

Patch missing NSS symbols for iOS x86_64 simulators #7242

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71055f2
fix: patch nss condition to account for iOS
issammani Feb 24, 2026
c92439d
chore: add tracking bug to comment
issammani Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions libs/build-nss-ios.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,16 @@ popd
# Build NSS
BUILD_DIR=$(mktemp -d)
rm -rf "${NSS_SRC_DIR}/nss/out"

# NSS 3.121 gcm.gyp sets HAVE_PLATFORM_GCM for x86_64 iOS
# simulator because 'target_arch=="x64" and OS!="win"' matches iOS.
# `intel-gcm-wrap` is not built for iOS and no lib provides
# platform_gcm_support for this target, causing a linker error.
# Until Bug 2019090 is fixed upstream, this will patch `gcm.gyp` to exclude iOS.
sed -i '' \
's/target_arch=="x64" and OS!="win"/target_arch=="x64" and OS!="win" and OS!="ios"/g' \
"${NSS_SRC_DIR}/nss/lib/freebl/gcm.gyp"

gyp -f ninja "${NSS_SRC_DIR}/nss/nss.gyp" \
--depth "${NSS_SRC_DIR}/nss/" \
--generator-output=. \
Expand Down