Bug 2012143 - Token exchange API #7179
Open
+217
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendk
commented
Jan 23, 2026
| } | ||
| // Get the updated refresh token from state. | ||
| refresh_token = match self.state.refresh_token() { | ||
| None => return Err(Error::NoCachedToken(scope.to_string())), |
Contributor
Author
There was a problem hiding this comment.
It feels like this error variant is misnamed, but it's already used to for scope issues in the code below so I guess we can just stick with it for now.
Contributor
Author
|
This is not working yet, we need mozilla/fxa#19928 to be merged first. Once that's merged, you should be able to test it out with |
bendk
force-pushed
the
push-rokxmqvqpntu
branch
3 times, most recently
from
7d14cf4 to
e67956c
Compare
* Implemented the token exchange API. * Added fxa-client CLI command to test the API. * Updated the logging so that we can use the CLI to trace the requests. * Added a constant for the relay scope and made the `scopes` module public. * Added support for specifying custom FxA servers in the CLI
bendk
force-pushed
the
push-rokxmqvqpntu
branch
from
e67956c to
2af727a
Compare
Gela
reviewed
Jan 23, 2026
| /// | ||
| /// The token server URL can be used to get the URL and access token for the user's sync data. | ||
| /// | ||
| /// **💾 This method alters the persisted account state.** |
There was a problem hiding this comment.
Apologies if this is normal in the app-services rust code, but I think the floppy disk emoji should be removed here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scopesmodule public.Pull Request checklist
[ci full]to the PR title.