Skip to content

Denying an appeal on Listing Content Rejection should drop requested#24632

Open
eviljeff wants to merge 1 commit intomozilla:masterfrom
eviljeff:16108-deny-appeal-for-listing-rejection-should-drop-requested
Open

Denying an appeal on Listing Content Rejection should drop requested#24632
eviljeff wants to merge 1 commit intomozilla:masterfrom
eviljeff:16108-deny-appeal-for-listing-rejection-should-drop-requested

Conversation

@eviljeff
Copy link
Member

@eviljeff eviljeff commented Mar 20, 2026

Fixes: mozilla/addons#16108

Description

Removes the requested status for content review if we deny their appeal - so the add-on no longer shows up in the reviewer tools queue.

Context

Testing

STR from the issue:

  • Reject listing content for an addon
  • As the owner of the addon send an appeal
  • See the add-on is in the content review queue
  • As a reviewer select the appeal from dsa section + deny appeal
  • The add-on shouldn't be in the content review queue any longer

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
  • Add before and after screenshots (Only for changes that impact the UI).
  • Add or update relevant docs reflecting the changes made.

@eviljeff eviljeff marked this pull request as ready for review March 20, 2026 11:36
@eviljeff eviljeff requested a review from diox March 20, 2026 11:36
Comment on lines +1003 to +1005
previous_decision_actions = (
self.decision.cinder_job.appealed_decisions.values_list('action', flat=True)
)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I could optimize this query to be an exists, as we're only interested in one case. I just kept it the same as we do in ContentActionTargetAppealApprove so it's understandable as the same concept. But I can rewrite if you prefer? (as with the unnecessary return None at the end of the function)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: deny appeal does not seem to work as expected in content-rejections

1 participant