Denying an appeal on Listing Content Rejection should drop requested#24632
Open
eviljeff wants to merge 1 commit intomozilla:masterfrom
Open
Denying an appeal on Listing Content Rejection should drop requested#24632eviljeff wants to merge 1 commit intomozilla:masterfrom
eviljeff wants to merge 1 commit intomozilla:masterfrom
Conversation
eviljeff
commented
Mar 20, 2026
Comment on lines
+1003
to
+1005
| previous_decision_actions = ( | ||
| self.decision.cinder_job.appealed_decisions.values_list('action', flat=True) | ||
| ) |
Member
Author
There was a problem hiding this comment.
I know I could optimize this query to be an exists, as we're only interested in one case. I just kept it the same as we do in ContentActionTargetAppealApprove so it's understandable as the same concept. But I can rewrite if you prefer? (as with the unnecessary return None at the end of the function)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#16108
Description
Removes the requested status for content review if we deny their appeal - so the add-on no longer shows up in the reviewer tools queue.
Context
Testing
STR from the issue:
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.