Move upload source step after details in submission flow#24589
Open
willdurand wants to merge 1 commit intomasterfrom
Open
Move upload source step after details in submission flow#24589willdurand wants to merge 1 commit intomasterfrom
willdurand wants to merge 1 commit intomasterfrom
Conversation
willdurand
force-pushed
the
move-source-code-to-end-of-flow
branch
2 times, most recently
from
f45af22 to
47cf88d
Compare
willdurand
force-pushed
the
move-source-code-to-end-of-flow
branch
from
47cf88d to
27e9f23
Compare
willdurand
requested review from
a team and
eviljeff
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#16133
In addition to changing the order of steps, I had to update a message. Indeed, we currently show a "remember" message conditionally in the "details" step:
In this patch, I replaced it with a different message since the source code is uploaded after: