Skip to content

Conversation

@bhearsum
Copy link
Contributor

No description provided.

@bhearsum
Copy link
Contributor Author

I guess we don't run checks against 3.8 here...but over in https://firefox-ci-tc.services.mozilla.com/tasks/A54t9llXTOO0joPcT2VKAA/runs/0/logs/live/public/logs/live.log we're seeing this:

[task 2025-05-28T14:47:00.532Z] Traceback (most recent call last):
[task 2025-05-28T14:47:00.532Z]   File "/builds/worker/checkouts/vcs/.tox/py38/bin/pytest", line 8, in <module>
[task 2025-05-28T14:47:00.532Z]     sys.exit(console_main())
[task 2025-05-28T14:47:00.532Z]   File "/builds/worker/checkouts/vcs/.tox/py38/lib/python3.8/site-packages/_pytest/config/__init__.py", line 201, in console_main
[task 2025-05-28T14:47:00.532Z]     code = main()
[task 2025-05-28T14:47:00.532Z]   File "/builds/worker/checkouts/vcs/.tox/py38/lib/python3.8/site-packages/_pytest/config/__init__.py", line 156, in main
[task 2025-05-28T14:47:00.532Z]     config = _prepareconfig(args, plugins)
[task 2025-05-28T14:47:00.532Z]   File "/builds/worker/checkouts/vcs/.tox/py38/lib/python3.8/site-packages/_pytest/config/__init__.py", line 341, in _prepareconfig
[task 2025-05-28T14:47:00.532Z]     config = pluginmanager.hook.pytest_cmdline_parse(
[task 2025-05-28T14:47:00.532Z]   File "/builds/worker/checkouts/vcs/.tox/py38/lib/python3.8/site-packages/pluggy/_hooks.py", line 513, in __call__
[task 2025-05-28T14:47:00.532Z]     return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
[task 2025-05-28T14:47:00.532Z]   File "/builds/worker/checkouts/vcs/.tox/py38/lib/python3.8/site-packages/pluggy/_manager.py", line 120, in _hookexec
[task 2025-05-28T14:47:00.532Z]     return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
[task 2025-05-28T14:47:00.532Z]   File "/builds/worker/checkouts/vcs/.tox/py38/lib/python3.8/site-packages/pluggy/_callers.py", line 139, in _multicall
[task 2025-05-28T14:47:00.532Z]     raise exception.with_traceback(exception.__traceback__)
[task 2025-05-28T14:47:00.532Z]   File "/builds/worker/checkouts/vcs/.tox/py38/lib/python3.8/site-packages/pluggy/_callers.py", line 122, in _multicall
[task 2025-05-28T14:47:00.532Z]     teardown.throw(exception)  # type: ignore[union-attr]
[task 2025-05-28T14:47:00.532Z]   File "/builds/worker/checkouts/vcs/.tox/py38/lib/python3.8/site-packages/_pytest/helpconfig.py", line 105, in pytest_cmdline_parse
[task 2025-05-28T14:47:00.532Z]     config = yield
[task 2025-05-28T14:47:00.532Z]   File "/builds/worker/checkouts/vcs/.tox/py38/lib/python3.8/site-packages/pluggy/_callers.py", line 103, in _multicall
[task 2025-05-28T14:47:00.532Z]     res = hook_impl.function(*args)
[task 2025-05-28T14:47:00.532Z]   File "/builds/worker/checkouts/vcs/.tox/py38/lib/python3.8/site-packages/_pytest/config/__init__.py", line 1140, in pytest_cmdline_parse

@bhearsum bhearsum requested a review from a team May 28, 2025 23:03
Copy link
Contributor

@jcristau jcristau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some level of 3.8 testing here?

@jcristau
Copy link
Contributor

Replying to myself, since we're close to replacing the old mac signers, maybe not.

@bhearsum bhearsum merged commit 2765b61 into mozilla-releng:main May 30, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants