Skip to content

Bugfix FXIOS-14132 ⁃ iPad - "Undo" not working for the last tab closed in tab tray #31181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dicarobinho wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bugfix FXIOS-14132 ⁃ iPad - "Undo" not working for the last tab closed in tab tray #31181

dicarobinho wants to merge 1 commit into from
+3 −3

Conversation

@dicarobinho
Copy link
Collaborator

@dicarobinho dicarobinho commented Dec 9, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

Moved guard for screenState

🎥 Demos

ScreenRecording_12-23-2025.11-49-11_1.mp4
Before After
Demo

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@dicarobinho dicarobinho marked this pull request as ready for review December 9, 2025 10:02
@dicarobinho dicarobinho requested a review from a team as a code owner December 9, 2025 10:02
@dicarobinho dicarobinho requested a review from yoanarios December 9, 2025 10:02
@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Dec 9, 2025

Messages
📖 Project coverage: 38.05%

🧹 Tidy commit

Just 1 file(s) touched. Thanks for keeping it clean and review-friendly!

✅ Per-file coverage

All changed files meet the threshold of 35.0%.

Client.app: Coverage: 37.09

File Coverage
TabManagerMiddleware.swift 25.58% ⚠️

Generated by 🚫 Danger Swift against b329b60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yoanarios yoanarios yoanarios approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dicarobinho @mobiletest-ci-bot @yoanarios