Conversation
currently used for toggling compromised lock behaviour
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
===========================================
+ Coverage 98.29% 100.00% +1.70%
===========================================
Files 4 6 +2
Lines 176 205 +29
Branches 45 50 +5
===========================================
+ Hits 173 205 +32
+ Misses 3 0 -3
Continue to review full report at Codecov.
|
|
@pimlie I would prefer to not add any option and actually make this the default. This means that the PR would be much simpler by just changing this to not throw: node-proper-lockfile/lib/lockfile.js Line 240 in c0cdea2 |
|
@satazor What about still removing the lock when its compromised? I guess you are opposed to that? The reason I added it because I actually like the idea that both processes will generate a warning untill we figured out why the lock was compromised in the first place. |
|
If the lock has been compromised, it usually means that someone else got the lock. It would be bad to delete the lock in that situation. |
feat: dont trigger error on compromised lock
|
Updated as requested :) |
Ref: #81
Strict mode is currently only used for toggling compromised lock behaviour