feat: add callback option when stale lock is reclaimed#106
Draft
albe wants to merge 1 commit intomoxystudio:masterfrom
Draft
feat: add callback option when stale lock is reclaimed#106albe wants to merge 1 commit intomoxystudio:masterfrom
albe wants to merge 1 commit intomoxystudio:masterfrom
Conversation
Author
|
One thing I'm not sure about is the race condition for the reclaiming now - if two processes start with a stale lock, then one starts to delete it, the other in the meantime acquires the lock and the second one then fails to acquire the lock, the callback will not be invoked and the information that a stale lock existed is lost. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #105
TODO: