Fixed extList2mimes function where mimes was used and overriden at the same time#1667
Open
GregOriol wants to merge 1 commit intomoxiecode:masterfrom
Open
Fixed extList2mimes function where mimes was used and overriden at the same time#1667GregOriol wants to merge 1 commit intomoxiecode:masterfrom
GregOriol wants to merge 1 commit intomoxiecode:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick fix to the extList2mimes function (which is not very useful, but anyway): in this function, the
mimesvariable declared above in the code is used withmimes[ext[ii]], but is also overridden locally with the same name. This make thetypevariable never correctly filled and the code failing to fill the mimes when needed. This PR fixes it.