Open
Conversation
richarddas
commented
May 1, 2015
richarddas
commented
- Component redraws after any property is set
- Updated delegate
- Added support for TintColor
- Added support for editing default parameters inside Interface Builder
+ Dots now use UIAppearance TintColor (blue by default) + Default values are calculated in custom getters, so we don't need to override all the initializers, and the component should now honour values set in Interface Builder for IBInspectables.
+ Cleaned up AutoLayout in view controller, so there's less code
+ Updated delegate method (activityIndicatorView:circleBackgroundColorAtIndex: -> activityIndicatorView:dotColorAtIndex:) + Resolved issue where updating the number of dots when the component was animating would have no effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.