Skip to content

chore: project infrastructure, code quality and CI/CD#2

Merged
konradmichalik merged 22 commits intomainfrom
chore/project-infrastructure
Apr 21, 2026
Merged

chore: project infrastructure, code quality and CI/CD#2
konradmichalik merged 22 commits intomainfrom
chore/project-infrastructure

Conversation

@konradmichalik
Copy link
Copy Markdown

Summary

  • Resolve all PHPStan level 8 errors across the extension codebase
  • Add unit tests for event classes and event listeners (9 tests, 13 assertions)
  • Add project metadata: CODE_OF_CONDUCT, CODEOWNERS, SECURITY.md
  • Add CI/CD release workflow for TER publishing on tag push
  • Add Renovate config for automated dependency updates
  • Add composer-dependency-analyser configuration
  • Normalize file headers and apply CGL formatting across all PHP files
  • Refactor code following KISS/YAGNI/DRY principles (duplicate dispatch logic, dead code, unused parameters)
  • Center README header with extension icon and shields.io badges
  • Declare missing php and psr/event-dispatcher composer dependencies
  • Add PHP 8.5 to CI test matrix
  • Expand .gitattributes export-ignore rules

Changes

  • Classes/Service/CopyService.php — PHPStan fixes, extract helper methods, remove fluent interface, deduplicate dispatch logic
  • Classes/Hooks/FormHooks.php — PHPStan fixes, extract rewrite logic, reuse CopyService instance, remove unused params
  • Classes/Finisher/SaveToDatabaseFinisher.php — PHPStan fixes, extract resolveElementValue, fix dead isset logic
  • Classes/FormElements/RepeatableContainerInterface.php — Add getElements/getProperties to interface contract
  • Classes/Event/CopyVariantEvent.php — Add array value type annotations
  • Tests/Unit/ — New tests for CopyVariantEvent, AfterBuildingFinishedEvent, AdaptVariantConditionEventListener
  • composer.json — Add php, psr/event-dispatcher, autoload-dev
  • .github/workflows/ — Add release.yml, add PHP 8.5 to tests.yml
  • CODE_OF_CONDUCT.md, CODEOWNERS, SECURITY.md, renovate.json — New project files

@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 24712416493

Warning

No base build found for commit 6973fb2 on main.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 9.399%

Details

  • Patch coverage: 191 uncovered changes across 4 files (1 of 192 lines covered, 0.52%).

Uncovered Changes

File Changed Covered %
Classes/Service/CopyService.php 98 0 0.0%
Classes/Finisher/SaveToDatabaseFinisher.php 58 0 0.0%
Classes/Hooks/FormHooks.php 34 0 0.0%
Classes/EventListener/AfterCurrentPageIsResolvedListener.php 1 0 0.0%

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 383
Covered Lines: 36
Line Coverage: 9.4%
Coverage Strength: 0.26 hits per line

💛 - Coveralls

@konradmichalik konradmichalik merged commit e8b0270 into main Apr 21, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants