build actin failure in sun bird plugin due to inclusion/exclusion strategies (#192)#196
build actin failure in sun bird plugin due to inclusion/exclusion strategies (#192)#196sacrana0 wants to merge 1 commit intomosip:release-1.4.xfrom
Conversation
WalkthroughAdded SonarCloud integration to the Maven project by introducing Sonar Maven plugin properties, CPD and coverage exclusion patterns, and a new Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use Trivy to scan for security misconfigurations and secrets in Infrastructure as Code files.Add a .trivyignore file to your project to customize which findings Trivy reports. |
…ategies (mosip#192) Signed-off-by: Md-Humair-KK <mdhumair.kankudti@gmail.com> Signed-off-by: Sachin Rana <sacrana324@gmail.com>
There was a problem hiding this comment.
🧹 Nitpick comments (1)
sunbird-rc-plugin/pom.xml (1)
84-87: Minor indentation inconsistency.Line 84 uses spaces while the rest of the file uses tabs for indentation. Consider aligning with the existing tab-based indentation for consistency.
Otherwise, the Sonar properties are correctly defined and match the patterns established in
mock-plugin/pom.xmlandmosip-identity-plugin/pom.xml.🔧 Suggested fix
- <maven.sonar.plugin.version>3.9.1.2184</maven.sonar.plugin.version> + <maven.sonar.plugin.version>3.9.1.2184</maven.sonar.plugin.version>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@sunbird-rc-plugin/pom.xml` around lines 84 - 87, The three Sonar property lines (maven.sonar.plugin.version, sonar.exclusions, sonar.cpd.exclusions, sonar.coverage.exclusions) use spaces for indentation while the file uses tabs; update those lines to use a single leading tab instead of spaces so their indentation matches the rest of the pom.xml formatting.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@sunbird-rc-plugin/pom.xml`:
- Around line 84-87: The three Sonar property lines (maven.sonar.plugin.version,
sonar.exclusions, sonar.cpd.exclusions, sonar.coverage.exclusions) use spaces
for indentation while the file uses tabs; update those lines to use a single
leading tab instead of spaces so their indentation matches the rest of the
pom.xml formatting.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 9fa46bdb-54fd-485d-a542-788f075ee646
📒 Files selected for processing (1)
sunbird-rc-plugin/pom.xml
Summary by CodeRabbit