Skip to content

build actin failure in sun bird plugin due to inclusion/exclusion strategies (#192)#196

Open
sacrana0 wants to merge 1 commit intomosip:release-1.4.xfrom
Infosys:sachin-dev
Open

build actin failure in sun bird plugin due to inclusion/exclusion strategies (#192)#196
sacrana0 wants to merge 1 commit intomosip:release-1.4.xfrom
Infosys:sachin-dev

Conversation

@sacrana0
Copy link
Contributor

@sacrana0 sacrana0 commented Mar 20, 2026

Summary by CodeRabbit

  • Chores
    • Added code quality analysis configuration for enhanced code scanning and quality monitoring.

@coderabbitai
Copy link

coderabbitai bot commented Mar 20, 2026

Walkthrough

Added SonarCloud integration to the Maven project by introducing Sonar Maven plugin properties, CPD and coverage exclusion patterns, and a new sonar build profile configured with source paths, exclusions, and execution bound to the verify phase.

Changes

Cohort / File(s) Summary
SonarCloud Maven Integration
sunbird-rc-plugin/pom.xml
Introduced SonarCloud-related Maven properties for plugin version and exclusion patterns; added inactive sonar profile configuring source paths, inclusions, exclusions, SonarCloud host URL, and sonar-maven-plugin execution bound to verify phase.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A sonar profile hops into place,
Maven builds now scan with grace,
SonarCloud gates await our code's review,
Quality metrics shining bright and true! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title mentions 'build actin failure' and 'inclusion/exclusion strategies' which directly relate to the SonarCloud Maven configuration added in the pom.xml (specifically the sonar.exclusions and sonar.inclusions properties being configured).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use Trivy to scan for security misconfigurations and secrets in Infrastructure as Code files.

Add a .trivyignore file to your project to customize which findings Trivy reports.

…ategies (mosip#192)

Signed-off-by: Md-Humair-KK <mdhumair.kankudti@gmail.com>
Signed-off-by: Sachin Rana <sacrana324@gmail.com>
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
sunbird-rc-plugin/pom.xml (1)

84-87: Minor indentation inconsistency.

Line 84 uses spaces while the rest of the file uses tabs for indentation. Consider aligning with the existing tab-based indentation for consistency.

Otherwise, the Sonar properties are correctly defined and match the patterns established in mock-plugin/pom.xml and mosip-identity-plugin/pom.xml.

🔧 Suggested fix
-        <maven.sonar.plugin.version>3.9.1.2184</maven.sonar.plugin.version>
+		<maven.sonar.plugin.version>3.9.1.2184</maven.sonar.plugin.version>
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@sunbird-rc-plugin/pom.xml` around lines 84 - 87, The three Sonar property
lines (maven.sonar.plugin.version, sonar.exclusions, sonar.cpd.exclusions,
sonar.coverage.exclusions) use spaces for indentation while the file uses tabs;
update those lines to use a single leading tab instead of spaces so their
indentation matches the rest of the pom.xml formatting.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@sunbird-rc-plugin/pom.xml`:
- Around line 84-87: The three Sonar property lines (maven.sonar.plugin.version,
sonar.exclusions, sonar.cpd.exclusions, sonar.coverage.exclusions) use spaces
for indentation while the file uses tabs; update those lines to use a single
leading tab instead of spaces so their indentation matches the rest of the
pom.xml formatting.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 9fa46bdb-54fd-485d-a542-788f075ee646

📥 Commits

Reviewing files that changed from the base of the PR and between f5e580b and b79dcb9.

📒 Files selected for processing (1)
  • sunbird-rc-plugin/pom.xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants