Add owner #43
Merged
Add owner #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathisGD
reviewed
Jul 5, 2023
Contributor
MathisGD
left a comment
MathisGD
left a comment
There was a problem hiding this comment.
NB: Blue does not even need an owner now, so we might temporize a little bit this one.
MathisGD
requested changes
Jul 5, 2023
Contributor
MathisGD
left a comment
MathisGD
left a comment
There was a problem hiding this comment.
Also it lacks some testing
Contributor
Author
Yes that's why I wrote:
|
Contributor
Author
|
The last 2 commits are not verified, I need to fix that EDIT: done |
pakim249CAL
previously approved these changes
Jul 5, 2023
MathisGD
reviewed
Jul 5, 2023
MathisGD
reviewed
Jul 6, 2023
Rubilmax
reviewed
Jul 6, 2023
Contributor
|
I would like to see an alternative version, that's included in Blue.sol directly (similar to UniV3) |
Contributor
|
Example in #67 |
Rubilmax
previously approved these changes
Jul 6, 2023
makcandrov
previously approved these changes
Jul 6, 2023
Rubilmax
approved these changes
Jul 6, 2023
MathisGD
approved these changes
Jul 6, 2023
pakim249CAL
approved these changes
Jul 6, 2023
QGarchery
approved these changes
Jul 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have several questions/thoughts:
dependenciesfolder?Ownable(orOwned) orOwnable2Step#15 I would lean toward the simplest way of doing this but it's debtablemsg.senderas owner so that it can easily be deployed by a deployer contract using CREATE2 without transferring the ownership.Depending on the answer of the above questions I can move forward with the related features requiring an owner (#41, #29)