fix: remove L1 eth rpc flag check

[tomatoishealthy]

Summary by CodeRabbit

• Style
  • Code formatting updates with no functional impact or user-visible changes.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Reformatting of the L1NodeAddr flag definition in the flags configuration file with whitespace and indentation adjustments. The flag name and value remain functionally identical with no behavior changes.

Changes

Cohort / File(s)	Summary
Flag formatting node/flags/flags.go	Whitespace and indentation reformatting of L1NodeAddr flag definition; flag name "l1.rpc" preserved

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A flag stood crooked, slightly askew,
We straightened its spacing, now shiny and new!
No logic was bent, no behavior did shift,
Just prettier lines—a formatting gift! 🐰✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title states 'remove L1 eth rpc flag check', but the actual change is only reformatting/whitespace adjustment to the L1NodeAddr flag definition with no functional change or removal of any check.	Update the title to accurately reflect the change, such as 'refactor: reformat L1NodeAddr flag definition' or similar, to match the actual whitespace/formatting adjustment made.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@node/flags/flags.go`:
- Around line 63-67: The flag L1NodeAddr (Name: "l1.rpc", EnvVar via
prefixEnvVar("L1_ETH_RPC")) was made optional but callers may still assume a
non-empty value; audit all usages of L1NodeAddr and
ctx.String("l1.rpc")/ctx.GlobalString("l1.rpc") and ensure each code path
validates the string before dialing or constructing L1 clients (e.g., in
functions like NewL1Client, l1.Dial, or any L1 client initialization). If the
URL is required for a mode, add explicit checks that return a clear error when
empty; if the flag is legitimately optional, add safe fallbacks / noop behavior
where used and document which node modes allow omission. Also verify any code
relying on the environment variable (L1_ETH_RPC / MORPH_NODE_L1_ETH_RPC) handles
absence identically.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Verify that all usages handle the optional L1 RPC endpoint.

The Required: true field was removed from the L1NodeAddr flag, making the L1 RPC endpoint optional. This is a significant behavioral change that could cause runtime errors if code assumes this value is always present.

Run the following script to verify that all code using the L1NodeAddr flag properly handles the case where it's not provided:

#!/bin/bash
# Description: Find all usages of L1NodeAddr and verify error handling for missing values

# Search for direct references to L1NodeAddr flag
echo "=== Direct references to L1NodeAddr flag ==="
rg -n 'L1NodeAddr' --type=go -C 3

echo -e "\n=== Flag value access via context (l1.rpc) ==="
# Search for code accessing the flag value via CLI context
rg -n 'ctx\.String\("l1\.rpc"\)|ctx\.GlobalString\("l1\.rpc"\)' --type=go -C 5

echo -e "\n=== Environment variable usage ==="
# Search for uses of the environment variable
rg -n 'L1_ETH_RPC|MORPH_NODE_L1_ETH_RPC' --type=go -C 3

echo -e "\n=== L1 client initialization ==="
# Search for L1 client/RPC initialization that might use this flag
rg -nP --type=go -C 5 'L1.*[Cc]lient|NewL1|l1.*[Dd]ial|l1.*[Rr]pc'

Ensure that:

1. All code paths check if the L1 RPC URL is empty before using it
2. Appropriate error messages are returned when the flag is required but not provided
3. There's a fallback mechanism or the flag is genuinely optional for certain node modes

🤖 Prompt for AI Agents

In `@node/flags/flags.go` around lines 63 - 67, The flag L1NodeAddr (Name:
"l1.rpc", EnvVar via prefixEnvVar("L1_ETH_RPC")) was made optional but callers
may still assume a non-empty value; audit all usages of L1NodeAddr and
ctx.String("l1.rpc")/ctx.GlobalString("l1.rpc") and ensure each code path
validates the string before dialing or constructing L1 clients (e.g., in
functions like NewL1Client, l1.Dial, or any L1 client initialization). If the
URL is required for a mode, add explicit checks that return a clear error when
empty; if the flag is legitimately optional, add safe fallbacks / noop behavior
where used and document which node modes allow omission. Also verify any code
relying on the environment variable (L1_ETH_RPC / MORPH_NODE_L1_ETH_RPC) handles
absence identically.