Skip to content

chore: remove unused ParseBusinessInfo helper #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Olexandr88 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: remove unused ParseBusinessInfo helper #854

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 0 additions & 36 deletions tx-submitter/utils/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,11 @@ import (
"time"

"morph-l2/bindings/bindings"
ntype "morph-l2/node/types"

"github.com/morph-l2/go-ethereum/accounts/abi"
"github.com/morph-l2/go-ethereum/common"
"github.com/morph-l2/go-ethereum/common/hexutil"
"github.com/morph-l2/go-ethereum/core/types"
"github.com/morph-l2/go-ethereum/log"
"github.com/morph-l2/go-ethereum/rpc"
)

Expand Down Expand Up @@ -164,40 +162,6 @@ func ParseMempoolLatestBatchIndex(id []byte, txs []*types.Transaction) uint64 {

}

func ParseBusinessInfo(tx *types.Transaction, a *abi.ABI) []interface{} {
// var method string
// var batchIndex uint64
// var finalizedIndex uint64
var res []interface{}
if len(tx.Data()) > 0 {
id := tx.Data()[:4]
if bytes.Equal(id, a.Methods["commitBatch"].ID) {
method := "commitBatch"
batchIndex := ParseParentBatchIndex(tx.Data()) + 1
res = append(res,
"method", method,
"batchIndex", batchIndex,
)
} else if bytes.Equal(id, a.Methods["finalizeBatch"].ID) {
method := "finalizeBatch"
parms, err := a.Methods["finalizeBatch"].Inputs.Unpack(tx.Data()[4:])
if err != nil {
log.Error("unpack finalizeBatch error", "err", err)
}
batchIndex, _ := ntype.BatchHeaderBytes(parms[0].([]byte)).BatchIndex()
res = append(res,
"method", method,
"finalizedIndex", batchIndex,
)

}

} else {
return []interface{}{}
}
return res
}

func ParseMethod(tx *types.Transaction, a *abi.ABI) string {
if tx.Data() == nil || len(tx.Data()) < 4 {
return ""
Expand Down