fix: fa component breaking font-subset (@miodec) #7446
+1,666
−1,664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting for review
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Font Awesome icon usage so icons are referenced with the literal fa- class names, ensuring the project’s Font Awesome font-subsetting process can detect and include the required glyphs.
Changes:
- Switch
Facomponent to accept full icon class names (e.g.,fa-ad) instead of building them at runtime. - Update icon references across UI components/tests to use
fa--prefixed icon strings. - Update Font Awesome TypeScript icon unions to require the
fa-prefix.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/ts/types/font-awesome.d.ts | Updates icon string unions to require fa- prefixes (improves subset detection + typing). |
| frontend/src/ts/components/common/Fa.tsx | Changes rendering to use the provided icon class directly instead of interpolating fa-${icon}. |
| frontend/src/ts/components/pages/AboutPage.tsx | Updates all page icons to fa--prefixed values. |
| frontend/src/ts/components/modals/SupportModal.tsx | Updates modal icons to fa--prefixed values. |
| frontend/src/ts/components/modals/ContactModal.tsx | Updates modal icons to fa--prefixed values. |
| frontend/src/ts/components/layout/overlays/Overlays.tsx | Updates overlay icon to fa--prefixed value. |
| frontend/src/ts/components/layout/overlays/Banners.tsx | Updates close icon to fa--prefixed value and adjusts z-index utility class. |
| frontend/src/ts/components/layout/footer/VersionButton.tsx | Updates footer icon to fa--prefixed value. |
| frontend/src/ts/components/layout/footer/ThemeIndicator.tsx | Updates theme indicator icons to fa--prefixed values. |
| frontend/src/ts/components/layout/footer/ScrollToTop.tsx | Updates scroll-to-top icon to fa--prefixed value. |
| frontend/src/ts/components/layout/footer/Footer.tsx | Updates footer button icons to fa--prefixed values. |
| frontend/src/ts/components/common/AsyncContent.tsx | Updates loader spinner icon to fa--prefixed value. |
| frontend/tests/components/Button.spec.tsx | Updates test icon strings to fa--prefixed values. |
| .github/copilot-instructions.md | Adds repo-specific Copilot guidance document. |
Miodec
changed the title
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.